Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename to stable #28823

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Rename to stable #28823

wants to merge 2 commits into from

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Nov 29, 2024

Description

Rename references to the stable branch. It will be called stable rather than master.

Open in GitHub Codespaces

Related issues

Relates to https://github.com/MetaMask/MetaMask-planning/issues/3677/

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@danjm danjm requested review from kumavis and a team as code owners November 29, 2024 19:24
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [79be051]
Page Load Metrics (1651 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint39318891599297143
domContentLoaded13831840161712359
load13941888165112359
domInteractive226629126
backgroundConnect990352512
firstReactRender1491262110
getState45176763015
initialActions01000
loadScripts10321468123711957
setupStore65510115
uiStartup159225721901211101
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -3 Bytes (-0.00%)

@Gudahtt Gudahtt force-pushed the rename-main-branch branch from 5a20bac to 259f0b7 Compare December 2, 2024 13:23
@Gudahtt Gudahtt requested review from a team and HowardBraham as code owners December 2, 2024 13:23
Base automatically changed from rename-main-branch to main December 2, 2024 14:00
@Gudahtt Gudahtt dismissed pedronfigueiredo’s stale review December 2, 2024 14:00

The base branch was changed.

@Gudahtt Gudahtt force-pushed the rename-master-branch branch from 79be051 to bacd267 Compare December 2, 2024 14:12
@Gudahtt
Copy link
Member

Gudahtt commented Dec 2, 2024

Rebased to resolve conflicts

docs/translating-guide.md Outdated Show resolved Hide resolved
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, found just one typo

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [296ac6b]
Page Load Metrics (1821 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint55421071765314151
domContentLoaded15192040179414369
load15272111182115273
domInteractive25149402813
backgroundConnect675292110
firstReactRender15502194
getState46108872210
initialActions00000
loadScripts11361588137012861
setupStore65315147
uiStartup17472335207115273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants